Add MVP of one-shot implementation #378
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppinchuk
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 39 out of 41 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
pyproject.toml:50
compass.utilities.ionow importsyamlandtomlat runtime, but neitherPyYAMLnor atomlpackage is listed in the project dependencies. This will raiseImportErrorin environments where they aren't installed transitively. Add the needed dependencies (or switch TOML loading to the stdlibtomllibfor Python 3.12+), and consider gating YAML/TOML support behind optional extras if you don't want them in the core install set.
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (53.03%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 57.03% 56.46% -0.57%
==========================================
Files 56 60 +4
Lines 4955 5366 +411
Branches 447 484 +37
==========================================
+ Hits 2826 3030 +204
- Misses 2086 2291 +205
- Partials 43 45 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core fundamentals for using one-shot extraction are in place.
Still TODO (future PR):